fix(charts): honour series opacity and dashArray on every series, not only a comparison one - #8159

Fixes #7698

@objectstack/spec declares ChartSeries.opacity ("Override series opacity") and ChartSeries.dashArray ("Override stroke dash pattern") as unconditional per-series overrides, and @object-ui/types' ChartDataSeriesSchema mirrors both. normalizeSeries read them off every series and the renderer then honoured them on a variant: 'comparison' overlay only — so an author who wrote { name: 'cost', opacity: 0.6 } on a primary series got a mark drawn exactly as if the key were absent. Option A per the card's adjudication: the renderer moves, not the declaration. Narrowing the published face to "comparison only" would be the renderer's tolerance dictating the contract, the direction AGENTS.md #0.1 forbids.

My own measurement — the card's body is wrong about where the defect lives, and the correction holds

Re-measured on origin/main @ c14d3a090 with the card's own census control rebuilt (grep -rniE 'opacity|dasharray' packages/plugin-charts/src, tests excluded). The card's body says all five cmp?.… call sites apply fillOpacity / strokeOpacity / strokeDasharray. They do not — and there are seven of them, not five (the body's list omits the two Line sites):

And comparisonStyle:96 was s.dashArray ?? (kind === 'line' || kind === 'area' ? '4 4' : undefined) — the ?? takes the left side whatever the kind, so the helper already returned an authored dash for bar and scatter too. Confirmed: what dropped it is the mark component, not the variant guard, and a fix aimed only at the guard would not have repaired dashArray at all.

The ablation below is the lit control for that claim, not the reading alone. Against the pre-fix implementation, the comparison-bar pin reports fillOpacity: '0.4' present and strokeDasharray: null — the muted default arrived, the authored dash did not. That is the mark-component half, isolated.

The fix — two halves, gated differently

comparisonStyle becomes seriesStyle and no longer returns null:

• Authored opacity / dashArray apply whatever the variant.
• The muted comparison DEFAULTS (lower opacity, the '4 4' line/area dash) stay gated on variant === 'comparison'.
• Bar and Scatter marks now pass strokeOpacity and strokeDasharray through, so the authored dash is no longer dropped at the mark.

Existing comparison series are byte-for-byte unaffected. The authored branch already won over the defaults, and the two stroke defaults no mark ever consumed (bar 0.6, scatter 0.5 — this renderer strokes neither family) are now spelled undefined, so opening strokeOpacity on those marks hands them no default they never had. Pinned directly: a comparison bar carrying no keys keeps fill-opacity="0.4" and gains neither stroke-opacity nor stroke-dasharray.

A primary series carrying neither key is untouched — pinned as all three attributes absent.

Only a stroked mark can show a dash, and this renderer strokes Line and Area, so an authored dashArray on a bar or scatter reaches the mark and paints nothing. That is the mark's geometry, not a condition on the key, and the docs now say exactly that rather than describing it as a restriction.

Read-coupling to PR #7684 (binding, discharged)

#7684 landed and stated the comparison-only condition as an interim measure. That wording is now wrong and comes out in this same change, per objectui#7070:

• packages/types/src/data-display.ts — the ChartDataSeries.opacity and .dashArray JSDoc. Comment-only: git diff -U0 on that file yields zero changed lines outside a block comment.
• content/docs/plugins/plugin-charts.mdx — both series-table rows plus the paragraph under the area example. Prose only: the three changed lines are 193, 194 and 198, and the fences in that region are 162-179, 200-216, so no compiled snippet moved.

Scope held

packages/core/src/utils/chart-presentation.ts was not touched — its seriesPresentation already forwards both keys on the dataset path, so the dispatch's flagged out-of-plugin file stays out of this PR.

Filed separately rather than folded in: objectui#8157 — the radar mark maps over series but hard-codes fillOpacity={0.6} and never calls the helper, so opacity, dashArray and the whole comparison treatment are inert on a radar chart for every variant. Repairing it would newly mute existing comparison radar series (0.6 becomes the helper's 0.5), a visible change to already-drawn charts that wants its own decision. Not addressed here; it stays open.

Not touched here either, all separate cards in the same measurement family: objectui#7690, objectui#7694, objectui#7682, objectui#7546.

Verification

All runs on the final commit 5d68aecbb unless stated. Heavy runs went through the container's shared verify lock; wall-clock figures are shared-box seconds.

Tests

• pnpm exec vitest run packages/plugin-charts/ — 48 files, 447 tests passed.
• pnpm exec vitest run packages/types/ packages/plugin-dashboard/ packages/plugin-report/ examples/schema-catalog/ — 271 files, 5611 tests passed (the chart-rendering consumers).
• New pin: packages/plugin-charts/src/ChartRenderer.seriesPresentation.test.tsx, 13 tests.

Reverse verification (ablation). Predicted direction: RED. The one file was restored to its c14d3a090 bytes, with the mutation proven on disk before the run — git hash-object of the working file equalled the pre-fix blob 63a5e34c9 and differed from the HEAD blob ae52b1d01; anchored counts moved seriesStyle 6 to 0 and comparisonStyle 0 to 6. Result: 8 of 13 failed, and the 5 that passed are exactly the regression pins (the comparison defaults, the untouched primary series, and an authored opacity overriding a comparison default — all of which held before this change and must keep holding). Restore leg proven by state, not by an exit code: git diff HEAD empty, git status clean, working blob back to ae52b1d01. The script carried an absolute-path trap ... EXIT INT TERM.

Type checking. pnpm --filter @object-ui/plugin-charts --filter @object-ui/types type-check — exit 0. This package's type-check is tsc --noEmit && tsc -p tsconfig.test.json, so the new test file is type-checked too rather than excluded.

Gates run locally (all exit 0, quoting each gate's own verdict line): check:control-bytes, check:vi-mock-specifiers, check:vi-mock-inherit, check:doc-fences, check:doc-types, check:doc-links, check:doc-expression-carriage, check:doc-example-readers, check:unreferenced-sources, check:spec-symbols, check:shell-escape-residue, check-changeset-presence, check-changeset-no-major, check-changeset-fixed, check-changeset-overwrite, and check-governed-queue-guard --test on all five changed paths (NOT GOVERNED, 5 of 5).

Two gates NOT MEASURED locally, left to CI — both exited on a stated precondition, neither is a finding:

• check:doc-snippets — exit 2, PRECONDITION NOT MET: it needs 32 packages plus closures built, which does not fit this container's foreground budget under contention. It compiles documented TS blocks, and this diff changes none (see the fence arithmetic above).
• check:eager-closure — exit 2, no apps/console/dist/eager-closure.json, so no ceiling to weigh. The diff adds no import, so the eager payload is unchanged.

Lint — a declared, measured narrowing. Repo-wide lint (turbo run lint, 40 packages each running eslint .) is CI's run. Locally, ESLint ran on the three changed source files: 3 files linted, 0 errors, 77 warnings, file count read from --format json output length. Every warning is pre-existing @typescript-eslint/no-explicit-any in AdvancedChartImpl.tsx; the diff adds no new any (the replaced helper already took s: any), and no --max-warnings is set anywhere in the lint pipeline — lint.yml says so in as many words. Invariance for untouched files: type-aware linting is not enabled — eslint.config.js sets no parserOptions.project and no projectService (the only matches in the repo are two RuleTester fixtures under eslint-rules/), so every verdict is a per-file function of that file's own bytes, and this diff cannot move the verdict of a file it does not touch.

Changeset. .changeset/7698-series-opacity-dasharray-unconditional.md, @object-ui/plugin-charts: minor + @object-ui/types: patch, no major (AGENTS.md version alignment). Not a skip-changeset PR — this ships a user-visible behaviour change.

🤖 Generated with Claude Code

https://claude.ai/code/session_01YBWFb5YgMU5dw8p2VKj16S

Generated by Claude Code